(PDK-430) Do not cache template-url answer if using the default template #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/pdk/generators/module.rb
Outdated
| @@ -68,7 +68,7 @@ def self.invoke(opts = {}) | |||
| end | |||
| end | |||
|
|
|||
| PDK.answers.update!('template-url' => template_url) | |||
| PDK.answers.update!('template-url' => template_url) unless template_url == default_template_url | |||
There was a problem hiding this comment.
I don't get the intent of the original line - is this updating the answer for template_url with a local copy of the template instead of the initial remote URL?
There was a problem hiding this comment.
as implemented this change also means that there is no way to reset to using the default without deleting/editing the ansers.json file.
There was a problem hiding this comment.
@james-stocks yeah, the intent is that if a user specifies a custom template URL (for example, a company which has their own internal module template that they'd like to use), it will be remembered for subsequent pdk new module runs.
@DavidS good point!
bmjen
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.