(PDK-450) remove stdlib dependency #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the stdlib dependency in there, but not in the rspec-puppet fixtures leads to painful expectations: stdlib functions are available, but using them in the code leads to test failures. Adding it to the fixtures would cause the default PDK workflow to require a online connection, so this instead removes the unforced dependency.
DavidS
force-pushed
the
remove-stdlib-dependency
branch
from
eac4e16 to
f6a431a
Compare
|
Code LGTM, and the approach of removing the dependency instead of adding more to the template to support it sound good; but the latter should maybe get one more +1 |
|
Yeah. For reference, https://tickets.puppetlabs.com/browse/PDK-460 also needs to be done to fully "solve" this issue. |
rodjek
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the stdlib dependency in there, but not in the rspec-puppet fixtures
leads to painful expectations: stdlib functions are available, but using
them in the code leads to test failures. Adding it to the fixtures would
cause the default PDK workflow to require a online connection, so this
instead removes the unforced dependency.