Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-415) Convert user-input related problems from FATAL to ERROR #293

Merged
merged 2 commits into from
Sep 13, 2017

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Sep 13, 2017

Adds a new exception type that should be raised when dealing with user input related problems (like trying to create a class that already exists).

asmodean :0: pdk/foo (git:pdk-415 → origin {2} ?:2!)$ ../bin/pdk new class foo
pdk (ERROR): Unable to generate class; '/home/tsharpe/code/puppet/pdk/foo/manifests/init.pp' already exists.

PDK::CLI::FatalError should still be used when catching and re-raising an exception, as those are almost always fatal errors and should be displayed as such.

Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, rekicked COVERAGE cell on travis to resuscitate coveralls.

@DavidS DavidS merged commit 52f5ecf into puppetlabs:master Sep 13, 2017
@DavidS
Copy link
Contributor

DavidS commented Sep 13, 2017

Merged without coverage report

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 93.685% when pulling a3cced5 on rodjek:pdk-415 into e7ec32a on puppetlabs:master.

@DavidS DavidS added the feature label Sep 13, 2017
@rodjek rodjek deleted the pdk-415 branch September 13, 2017 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants