Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-502) make the private git available to module commands #298

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Sep 20, 2017

Git on Windows doesn't seem to automatically find its component binaries, so we need to add them to the path in order for the vendored git to work properly.

Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid.

Since you are already in there, another question to consider is if we really want to override a user's install, if they have a git configured? In case of a conflict, it's probably bad either way.

Feel free to merge at will.

@rodjek
Copy link
Contributor Author

rodjek commented Sep 20, 2017

@DavidS 👍 moved the vendored git path to the end of PATH so the user's git install will take precedence if present.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 93.371% when pulling 2514f8b on rodjek:gh-297 into 7b3374b on puppetlabs:master.

@puppetlabs puppetlabs deleted a comment from coveralls Sep 20, 2017
@puppetlabs puppetlabs deleted a comment from coveralls Sep 20, 2017
@rodjek rodjek merged commit f29b071 into puppetlabs:master Sep 20, 2017
@rodjek rodjek deleted the gh-297 branch September 20, 2017 23:29
@DavidS DavidS added the bug label Oct 4, 2017
@DavidS DavidS changed the title (PDK-502) Add git mingw paths to PATH (PDK-502) make the private git available to module commands Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants