Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --relative cli argument for autoload layout testing in puppet-lint #325

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

spacepants
Copy link

When validating a module via pdk validate, puppet-lint fails validation for its autoloader_layout check if the module directory is not the exact module name, i.e. if validating an ntp module, puppet-lint passes /path/ntp but fails /path/puppetlabs-ntp.

This passes the --relative argument to puppet-lint to ignore the top-most directory of the module and pass in both of the previous examples. Hopefully this should help with module conversion.

More info: rodjek/puppet-lint#245
and rodjek/puppet-lint#252

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.295% when pulling d1cd252 on spacepants:relative-autoload-layout into c67927f on puppetlabs:master.

Copy link
Contributor

@bmjen bmjen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, thanks @spacepants !

I'll wait to merge this until the puppet-lint PRs are merged and released.

@bmjen bmjen merged commit 1ff9e67 into puppetlabs:master Oct 16, 2017
@bmjen bmjen added the bug label Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants