-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PDK-628) Addition of module_name question to interview #327
Conversation
407f9fa
to
4118b42
Compare
4118b42
to
a666b20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't implement PDK-628:
david@davids:~/git/pdk$ git describe --all --long
heads/questionname-0-ga666b20
david@davids:~/git/pdk$ ./bin/pdk new module
NAME
module - Create a new module named <module_name> using given options
[...]
(although, having said that, we might want to merge this as first step, and come back later to finish implementation) |
I think it makes sense to split pdk-628 into two PRs (this one to modify the interview in order to accommodate the convert functionality and a follow up one that modifies the CLI functionality) |
This enables the re-use of the modules interview with pdk convert without disturbing generate new module workflow.
a666b20
to
fc0e834
Compare
I've successfully ran the acceptance:local tests on my machine to stand in until travis fixes their bundler issue. |
Adds the module_name question to the interview without disturbing generate functionality.
Also includes two cleanups: