-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PDK-626) Templatedir can now handle multiple directories #340
Conversation
This PR won't pass acceptance tests while https://github.com/puppetlabs/pdk-module-template/pull/56 isn't merged. Both of these PRs will need merged at the same time as their functionality depends on one another. |
The new code should not fail just because there is no Once that is changed, the next question raised is how to test the additions without depending on "the" template. It'll cause more work now, but make the project more nimble, if you add a local example template for integration testing, that can be modified to exercise the code without external dependencies. Finally, we still do not test the whole workflow end-to-end with pushing a new module to github/travis/appveyor. But that, again, is a new ticket. |
@DavidS The issue is that if we don't fail on no moduleroot_init being present, there is the potential that only half the files will be generated (whatever ends up being in moduleroot, assuming we are using the new template style), but I get your point. |
e04b32c
to
452957c
Compare
452957c
to
f2260df
Compare
Required for the new 'convert' functionality - The aim of this update is so that files needed for convert are kept in a default directory, while new requires additional directories that will be found in the 'moduleroot_init'.
f2260df
to
7facba3
Compare
Required for the new 'convert' functionality - The aim of this update is so that files needed for convert are kept in a default directory,
while new requires additional directories that will be found in the 'moduleroot_init'.