(PDK-643) Remove escape sequence spam when running in CI systems #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determines if the process is being run interactively by checking if stderr is a TTY and only create the spinners when the PDK is run interactively.
Acceptance tests for this proved to be troublesome as the specinfra exec backend doesn't support creating a PTY. I created a new backend for specinfra but it turns out that Windows doesn't support PTYs anyway, so that had to be thrown away and I've instead gone for an environment variable (h/t to DEBIAN_FRONTEND) to override the TTY check during tests.