-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PDK-728) Add default_template_ref handler. #377
Conversation
lib/pdk/module/templatedir.rb
Outdated
else # TODO: Once we decide on a branching strategy for the pdk-module-template, this needs to be updated. | ||
PDK::Util::Git.git('clone', path_or_url, '--branch', 'convert', temp_dir) | ||
end | ||
clone_result = PDK::Util::Git.git('clone', path_or_url, '--branch', PDK::Util.default_template_ref, temp_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider making this a clone
and then reset --hard
to the desired ref. clone --branch
only supports branches and tags. This is probably fine for now though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea. Going to hold off on merging this and potentially breaking the vanagon build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to clone && reset
No description provided.