Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-772) Refactor PDK::Module::Convert for re-use in PDK::Module::Update #421

Merged
merged 5 commits into from
Feb 16, 2018

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Feb 8, 2018

Implements pdk update with unit and acceptance tests. This PR covers PDK-772 and PDK-773 as they pretty much had to be worked on in parallel and PDK-773 depends on PDK-772. If needed, we can cherry-pick the last 2 commits into their own PR for PDK-773.

@coveralls
Copy link

coveralls commented Feb 8, 2018

Coverage Status

Coverage increased (+0.2%) to 92.301% when pulling 409dd13 on rodjek:pdk-772 into 85c33fa on puppetlabs:master.

@rodjek rodjek force-pushed the pdk-772 branch 9 times, most recently from dbdfd9e to a2437cd Compare February 14, 2018 08:43
@rodjek rodjek changed the title [WIP] (PDK-772) Refactor PDK::Module::Convert for re-use in PDK::Module::Update (PDK-772) Refactor PDK::Module::Convert for re-use in PDK::Module::Update Feb 14, 2018
@rodjek rodjek requested review from bmjen and scotje February 14, 2018 09:17
@rodjek rodjek merged commit fffe46a into puppetlabs:master Feb 16, 2018
@rodjek rodjek deleted the pdk-772 branch February 16, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants