Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-846) add Resource API type unit test template #451

Merged
merged 1 commit into from
Mar 16, 2018
Merged

(PDK-846) add Resource API type unit test template #451

merged 1 commit into from
Mar 16, 2018

Conversation

tphoney
Copy link
Contributor

@tphoney tphoney commented Mar 16, 2018

No description provided.

@coveralls
Copy link

coveralls commented Mar 16, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 92.105% when pulling e0847e1 on tphoney:PDK-846 into b798efa on puppetlabs:master.

@tphoney
Copy link
Contributor Author

tphoney commented Mar 16, 2018

describe command('pdk new provider --template-url /Users/tp/workspace/git/pdk-templates test_provider') do

@tphoney
Copy link
Contributor Author

tphoney commented Mar 16, 2018

For the tests to pass we need the new templates @ puppetlabs/pdk-templates#40
UNIT TESTS
Finished in 1.57 seconds (files took 1.54 seconds to load)
734 examples, 0 failures
ACCEPTANCE TESTS
Finished in 7 minutes 39 seconds (files took 1.39 seconds to load)
427 examples, 0 failures

@tphoney tphoney requested a review from DavidS March 16, 2018 13:45
@tphoney tphoney changed the title {WIP} (PDK-846) add Resource API type unit test template (PDK-846) add Resource API type unit test template Mar 16, 2018
@DavidS DavidS merged commit f28a9ad into puppetlabs:master Mar 16, 2018
@bmjen bmjen added the feature label Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS DavidS Awaiting requested review from DavidS

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tphoney @coveralls @DavidS @bmjen