Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-831, PDK-832) Fix ability to unmanage/delete files via .sync.yml #479

Merged
merged 3 commits into from
Apr 17, 2018
Merged

(PDK-831, PDK-832) Fix ability to unmanage/delete files via .sync.yml #479

merged 3 commits into from
Apr 17, 2018

Conversation

bmjen
Copy link
Contributor

@bmjen bmjen commented Apr 17, 2018

Also includes:

  • a fix for an unreported bug where .sync.yml wasn't being read if pdk convert was being performed on a module without a metadata.json.
  • added accessor to update/set module_metadata in the TemplateDir.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.134% when pulling 669f831 on bmjen:pdk-831-832 into dd678f4 on puppetlabs:master.

rodjek
rodjek approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@rodjek rodjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Unit test coverage dropped a bit, but the changes are covered by the acceptance tests so I don't think that should be a blocker.

@rodjek rodjek merged commit d530d13 into puppetlabs:master Apr 17, 2018
@bmjen bmjen deleted the pdk-831-832 branch April 17, 2018 15:33
@bmjen bmjen added the bug label Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek rodjek approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmjen @coveralls @rodjek