(PDK-802) Work around OpenSSL multi-threading errors when needed #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, my unit test expectations are wrong, will fix tomorrow. |
glennsarti
reviewed
May 1, 2018
See https://bugs.ruby-lang.org/issues/11033 for background. TL;DR is that there was a bug in the Ruby 'openssl' gem that caused a race condition on Windows when loading certs. I think this is the cause of "cert already in hash table" transient failures we see in Appveyor as well as some of the issues @glennsarti was encountering in https://tickets.puppetlabs.com/browse/PDK-802 Ruby issue linked above was backported to Ruby 2.3 branch and released in 2.3.5, however Appveyor is still on 2.3.3 for Ruby23 target. Inside PDK packages it should only be an issue on the Ruby 2.1.9 bundler invocations.
scotje
force-pushed
the
windows_openssl_multithreading
branch
from
a267190 to
de581c3
Compare
|
Mocked out the platform and version checks in the unit tests so hopefully this will pass cross-platform now. Also expanded the commit message to include my comments from the PR description. |
bmjen
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For post-1.5.0 bug bashing consideration.
See https://bugs.ruby-lang.org/issues/11033 for background.
I think this is the cause of our "cert already in hash table" transients in Appveyor as well as some of the issues @glennsarti was encountering in https://tickets.puppetlabs.com/browse/PDK-802
Ruby issue linked above was backported to Ruby 2.3 branch and released in 2.3.5, however Appveyor is still on 2.3.3 for Ruby23.
Inside PDK packages it should only be an issue on the 2.1.9 bundler invocations.