-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PDK-985) Split validation targets into chunks of 1000 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rodjek is this still WIP? |
rodjek
force-pushed
the
pdk-985
branch
3 times, most recently
from
June 7, 2018 06:04
f4c3d16
to
0f51753
Compare
rodjek
changed the title
[WIP] (PDK-985) Split validation targets into chunks of 1000
(PDK-985) Split validation targets into chunks of 1000
Jun 7, 2018
@scotje Not any more :) |
There seem to be some issues with how the new code interacts with the multispinner:
vs master:
I'm going to see if I can figure out what is going on. |
https://tickets.puppetlabs.com/browse/PDK-1032 Was created to track and fix the multi-spinner display. |
bmjen
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work around argument list length limits.