New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1041) Improve handling of errors from PDK::Module::TemplateDir #545

Merged

bmjen merged 2 commits into puppetlabs:master from rodjek:pdk-1041

Jul 11, 2018

Contributor

rodjek commented Jul 11, 2018

Capture the ArgumentErrors generated by PDK::Module::TemplateDir during convert and expose them nicely via the CLI.
Add a special case to the template validation logic to detect if the user is trying to update a module that was generated using a built-in template that no longer exists.

rodjek added 2 commits

July 11, 2018 15:42


          (PDK-1041) Handle PDK::Module::TemplateDir errors in the CLI

5e846d2


          (PDK-1041) Display a specific error if the built-in module path changes

dda120d

rodjek force-pushed the pdk-1041 branch from d344870 to dda120d Compare

July 11, 2018 05:43

coveralls commented Jul 11, 2018 •

edited

Loading

Coverage decreased (-0.1%) to 92.792% when pulling dda120d on rodjek:pdk-1041 into 678315f on puppetlabs:master.

bmjen approved these changes

View reviewed changes

bmjen merged commit cb7e829 into puppetlabs:master

rodjek deleted the pdk-1041 branch

July 16, 2018 00:14

chelnak added the feature label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels