Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1045) Send validation targets as relative file paths #549

Merged
merged 2 commits into from
Jul 16, 2018

Conversation

bmjen
Copy link
Contributor

@bmjen bmjen commented Jul 12, 2018

Update the validator to parse targets and return results as file paths
relative to the module root. This is to cut down on the character length
of the command string, since the full path of the module directory is
unnecessary and long module_root paths may end up hitting the maximum
character limit on Windows.

@coveralls
Copy link

coveralls commented Jul 12, 2018

Coverage Status

Coverage increased (+0.008%) to 92.799% when pulling c443c84 on bmjen:pdk_1045 into 4a73b87 on puppetlabs:master.

Copy link
Contributor

@rodjek rodjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to get an acceptance test for this scenario going as I'm worried that even with this change, doing a validate on a module with say 3000 files will still cause an issue on Windows.

Bryan Jen added 2 commits July 13, 2018 15:16
Update the validator to parse targets and return results as file paths
relative to the module root. This is to cut down on the character length
of the command string, since the full path of the module directory is
unnecessary and long module_root paths may end up hitting the maximum
character limit on Windows.
@rodjek rodjek merged commit bc3667e into puppetlabs:master Jul 16, 2018
@bmjen bmjen deleted the pdk_1045 branch July 16, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants