(PDK-1200) Fix bundle env handling with puppet-dev #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
reviewed
Oct 25, 2018
| end | ||
| end | ||
| end | ||
| TESTFILE |
There was a problem hiding this comment.
This method seems a little round-about to me...
Could we update the test manifest to have two specific tests that assert either the presence or absence of the path key and then below use pdk test unit --tests= to only invoke the specific test and assert that it passed?
There was a problem hiding this comment.
I've updated the test to expect the path... so the acceptance test was simplified to expect a PDK test success or failure.
|
Should this change also be applied to |
bmjen
force-pushed
the
pdk-1200
branch
2 times, most recently
from
ee0e1d8 to
818b9e8
Compare
Bundler requires that you continue to pass in PUPPET_GEM_VERSION when doing check, install, and exec. Previously we were only setting the puppet gem env when doing a bundle check and updating the lock file.
bmjen
force-pushed
the
pdk-1200
branch
3 times, most recently
from
cdbf095 to
a3737da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundler requires that you continue to pass in PUPPET_GEM_VERSION
when doing check, install, and exec. Previously we were only setting
the puppet gem env when doing a bundle check and updating the lock file.