(PDK-400) Output the rspec run wall time in test unit summary #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `pdk test unit` outputs the time rspec took to evaluate the tests in the summary (which is always significantly shorter than the time taken to execute the command) while `pdk test unit --parallel` outputs the wall time for parallel_spec. This leads to a confusing situation where running tests in parallel seems to be slower than running the tests sequentially. This PR changes the behaviour so that the wall time is always printed (which is, in my humble opinion, the more useful metric in most cases).
bmjen
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
pdk test unitoutputs the time rspec took to evaluate thetests in the summary (which is always significantly shorter than the
time taken to execute the command) while
pdk test unit --paralleloutputs the wall time for parallel_spec. This leads to a confusing
situation where running tests in parallel seems to be slower than
running the tests sequentially.
This PR changes the behaviour so that the wall time is always printed
(which is, in my humble opinion, the more useful metric in most cases).