Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1104) Don't always override custom template url with default #597

Merged
merged 1 commit into from
Nov 26, 2018
Merged

(PDK-1104) Don't always override custom template url with default #597

merged 1 commit into from
Nov 26, 2018

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Nov 22, 2018

In most of the generators, the fact that we specify a default value for
the --template-url option overrides any template specified in the
metadata or answers.json.

@rodjek
(PDK-1104) Don't always override custom template url with default
320765f 
In most of the generators, the fact that we specify a default value for
the `--template-url` option overrides any template specified in the
metadata or `answers.json`.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 92.996% when pulling 320765f on rodjek:pdk-1104 into 387ff02 on puppetlabs:master.

@bmjen bmjen merged commit c07b3ae into puppetlabs:master Nov 26, 2018
@bmjen bmjen added the bug label Nov 26, 2018
@rodjek rodjek deleted the pdk-1104 branch November 26, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmjen bmjen bmjen approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodjek @coveralls @bmjen