(PDK-1338) Initial import of analytics code from Bolt #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
reviewed
Apr 4, 2019
glennsarti
reviewed
Apr 4, 2019
glennsarti
reviewed
Apr 4, 2019
glennsarti
reviewed
Apr 4, 2019
| @@ -36,6 +36,8 @@ Gem::Specification.new do |spec| | |||
| spec.add_runtime_dependency 'ffi', '~> 1.9.0' | |||
| spec.add_runtime_dependency 'hitimes', '1.3.0' | |||
| spec.add_runtime_dependency 'net-ssh', '~> 4.2.0' | |||
| spec.add_runtime_dependency 'httpclient', '~> 2.8.3' | |||
| spec.add_runtime_dependency 'concurrent-ruby', '~> 1.1.5' | |||
There was a problem hiding this comment.
IIRC this is compiled gem. No issues with this?
There was a problem hiding this comment.
It will get compiled as part of the vanagon build process and the results cached into the packages, so it should be OK.
glennsarti
reviewed
Apr 4, 2019
scotje
reviewed
Apr 4, 2019
rodjek
force-pushed
the
pdk-1338
branch
5 times, most recently
from
049b0e5 to
e73d982
Compare
rodjek
changed the title
scotje
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.