Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1348) remove unused constants throwing warns #656

Merged
merged 1 commit into from
Apr 10, 2019
Merged

(PDK-1348) remove unused constants throwing warns #656

merged 1 commit into from
Apr 10, 2019

Conversation

tphoney
Copy link
Contributor

@tphoney tphoney commented Apr 9, 2019

No description provided.

@coveralls
Copy link

coveralls commented Apr 9, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 93.025% when pulling 4b02f0c on tphoney:PDK-1348 into 3ecd626 on puppetlabs:master.

@glennsarti
Copy link
Contributor

Might be best to rescope the constants to PDK::Util::Windows and use that instead of using raw values. Calling Win32 APIs is notoriously "odd" and the variable names help to keep it consistent across codebases (and sanity)

@tphoney tphoney added the bug label Apr 9, 2019
@tphoney
Copy link
Contributor Author

tphoney commented Apr 9, 2019

@glennsarti is this ok ?

scotje
scotje approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll let @glennsarti have another look before we merge.

glennsarti
glennsarti approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipit

@scotje scotje merged commit 04407a5 into puppetlabs:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennsarti glennsarti glennsarti approved these changes

@scotje scotje scotje approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tphoney @coveralls @glennsarti @scotje