(PDK-1300) Ensure test unit --list uses correct Puppet/Ruby env
#660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `pdk test unit --list` would always run under PDK's default Ruby runtime, which could cause a Bundler error if the module had never had `ensure_bundle` called for that runtime.
|
Spent a bunch of time this afternoon debugging the acceptance test failure, but now it's showing up on |
scotje
force-pushed
the
1300_test_unit_list_ruby_env
branch
2 times, most recently
from
98cfb77 to
26ebab9
Compare
rodjek
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
pdk test unit --listwould always run under PDK's defaultRuby runtime, which could cause a Bundler error if the module had never
had
ensure_bundlecalled for that runtime.