(PDK-1264) Display a nicer error when tarring long paths #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
force-pushed
the
pdk-1264
branch
2 times, most recently
from
42e9bbb to
5a9367d
Compare
rodjek
changed the title
scotje
approved these changes
May 14, 2019
| rescue ArgumentError => e | ||
| raise PDK::CLI::ExitWithError, _( | ||
| '%{message} Please rename the file or exclude it from the package ' \ | ||
| 'by adding it to the .pdkignore file in your module.', |
There was a problem hiding this comment.
I think the subtle distinction between the two failure cases is probably not worth surfacing to the user in this message and we can just say that the path is too long here. We can log the distinction at DEBUG perhaps?
There was a problem hiding this comment.
I was thinking that, but say there is a file in the root of the module called this_is_a_file_name_that_goes_over_100_characters_oh_no.md, it would fail but would clearly be < 256 bytes which would make a generic error confusing.
|
Forced pushed an amended commit with the comment fixed up. Will merge after CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we'd upgrade minitar to 0.8 which supports long paths, but the rest of the Puppet ecosystem is using minitar 0.6.1, which would result in building packages that r10k or PMT couldn't install. Also, upgrading minitar to 0.8 causes dependency hell with all the gems that have a
~> 0.6.1minitar dependency.Instead, we now display an error explaining the problem and asking the user to rename the file or exclude the file from the build before trying again.