Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FIXUP) Avoid attempting to append nokogiri pin to nil in package tests #686

Merged
merged 1 commit into from
Jun 25, 2019
Merged

(FIXUP) Avoid attempting to append nokogiri pin to nil in package tests #686

merged 1 commit into from
Jun 25, 2019

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Jun 25, 2019

Avoid undefined method << on a possibly nil value during package tests.

@scotje scotje requested a review from rodjek June 25, 2019 21:55
@scotje scotje force-pushed the fixup_package_tests branch from 8be7235 to fb39280 Compare June 25, 2019 21:56
@coveralls
Copy link

coveralls commented Jun 25, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 93.079% when pulling fb39280 on scotje:fixup_package_tests into 5f54d20 on puppetlabs:master.

@scotje scotje changed the title (FIXUP) Avoid attemping to append nokogiri pin to nil in package tests (FIXUP) Avoid attempting to append nokogiri pin to nil in package tests Jun 25, 2019
@rodjek rodjek merged commit e7ea778 into puppetlabs:master Jun 25, 2019
@chelnak chelnak added the bug label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek rodjek approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scotje @coveralls @rodjek @chelnak