(PDK-1414) Detect common CI environments and set non-interactive #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
detect-ci
branch
3 times, most recently
from
fbacb7a to
8bd9707
Compare
Previously PDK detected whether a session was interactive by using the isatty method on STDERR. However it is still possible to create TTY based STDERR in CI environments such as Travis. This commit adds additional Environment Variable checks for common CI systems to ensure that PDK is non-interactive in CI.
|
Created https://tickets.puppetlabs.com/browse/PDK-1414 to track and amended the commit message to include ticket number. |
scotje
changed the title
scotje
approved these changes
Jun 28, 2019
smortex
reviewed
Jun 28, 2019
Also refactored slightly to use Enum#any? instead of #each with return
rodjek
approved these changes
Jun 30, 2019
logicminds
pushed a commit
to nwops/pdk
that referenced
this pull request
Nov 30, 2020
…petlabs#689) * (PDK-1414) Detect common CI environments and set non-interactive Previously PDK detected whether a session was interactive by using the isatty method on STDERR. However it is still possible to create TTY based STDERR in CI environments such as Travis. This commit adds additional Environment Variable checks for common CI systems to ensure that PDK is non-interactive in CI. * (FIXUP) Add "CI" and "CONTINUOUS_INTEGRATION" to list Also refactored slightly to use Enum#any? instead of #each with return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously PDK detected whether a session was interactive by using the isatty
method on STDERR. However it is still possible to create TTY based STDERR in
CI environments such as Travis. This commit adds additional Environment
Variable checks for common CI systems to ensure that PDK is non-interactive in
CI.