-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PDK-1432) Autogenerate PowerShell modules from code #701
Conversation
6995603
to
f0637bb
Compare
f0637bb
to
d69e290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor things but looks good overall!
Does module autoload conflict anything? I don't see any function or cmdlet name overlap, but the env variables are the same |
Bouncing PR as a test |
As far as I can tell, no. And the shared env vars are sane. Not sure what the motivation behind the question is? Are you wondering if it should be one module? Note that we need changes to pdk-vanagon for this to take effect. |
d69e290
to
6a45c9e
Compare
The reason I ask about the env variables is that some are different:
I was unsure if the module scope would save us, or are environment variables global scoped regardless of when/where they are created? The case I'm thinking is user loads old module, does some things, tries out new module and does some things, then goes back to old but ruby_dir is wrong now so it fails. |
Ahh whoops yes...one of them is wrong. Based on older and new PDK versions Env will be process level |
Previously the PowerShell module code lived in the pdk-vanagon repository however during release this required manual steps. This commit moves the PowerShell module files to this repository and allows the use of ERB to update them, for example, version and copyright year. This commit also adds a beta PowerShell module which provides a much richer and native PowerShell experience, by autogenerating from the CRI information.
6a45c9e
to
e31e0c2
Compare
@jpogran Fixed the env vars issue. I wonder if I should make that an interpolated value so at least it's consistent... |
I don't think that's required for this PR. I think that is more part of the work to get the beta module to a version 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glennsarti It looks like @jpogran approved this, so is there anything else we are waiting on before we merge this? |
Previously the PowerShell module code lived in the pdk-vanagon repository
however during release this required manual steps. This commit moves the
PowerShell module files to this repository and allows the use of ERB to update
them, for example, version and copyright year.
This commit also adds a beta PowerShell module which provides a much richer
and native PowerShell experience, by autogenerating from the CRI information.