(PDK-1434) Gracefully handle unparsable bolt analytics config #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
reviewed
Jul 11, 2019
This issue was found because the classroom Windows instances created the `~/puppetlabs/bolt/analytics.yaml` manually with UTF-16LE encoding which Psych on Windows is unable to parse, causing `PDK::Config.bolt_analytics_config` to raise `PDK::Config::LoadError`. The classroom bootstrap scripts have been fixed to generate the file as UTF-8 now, but we should still gracefully handle this case and have PDK behave as if the file doesn't exist and use the default values.
glennsarti
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was found because the classroom Windows instances created the
~/puppetlabs/bolt/analytics.yamlmanually with UTF-16LE encoding whichPsych on Windows is unable to parse, causing
PDK::Config.bolt_analytics_configto raisePDK::Config::LoadError.The classroom bootstrap scripts have been fixed to generate the file as
UTF-8 now, but we should still gracefully handle this case and have PDK
behave as if the file doesn't exist and use the default values.