(PDK-1107) Config fetch and [] should have no side effects #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Previously even querying a configuration setting would save the default value to disk. This is undesirable, and not expected as a user, because not all defaults should persist on disk, across multiple PDK sessions/projects/modules. This commit: * Modifies the Config::Namespace class to have a new parameter called persistent_defaults. * Modified the [] and fetch methods in Namespace to optioally call save_data when a default value is queried and persistent_defaults is set to true. This is affected in #default_config_value method. * Added a wrapper method for mkdir_p for the FileSystem class so it could be mocked correctly in tests. Currently it was creating folder structures in the root of the PDK project. * Updated the namespace and config tests to ensure that the analytics settings use the persistent_defaults Namespace setting.
glennsarti
force-pushed
the
get-should-not-side-effect
branch
from
573a030 to
de73b47
Compare
scotje
approved these changes
Aug 8, 2019
|
@scotje Yes. I extracted this commit from |
|
Will wait for +1 from @rodjek before merge. |
rodjek
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously even querying a configuration setting would save the default value to
disk. This is undesirable, and not expected as a user, because not all defaults
should persist on disk, across multiple PDK sessions/projects/modules. This
commit:
persistent_defaults.
when a default value is queried and persistent_defaults is set to true. This
is affected in #default_config_value method.
mocked correctly in tests. Currently it was creating folder structures in the
root of the PDK project.
use the persistent_defaults Namespace setting.