Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-871) Relax dependencies on tty-* gems #730

Merged
merged 1 commit into from
Aug 14, 2019
Merged

(PDK-871) Relax dependencies on tty-* gems #730

merged 1 commit into from
Aug 14, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Aug 14, 2019

No description provided.

@rodjek rodjek requested review from scotje and glennsarti August 14, 2019 08:43
scotje
scotje approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@scotje
Copy link
Contributor

scotje commented Aug 14, 2019

Spec tests in Travis passed with latest tty-* gems:

Using tty-reader 0.6.0
Using tty-prompt 0.19.0
Using tty-spinner 0.9.1
Using tty-which 0.4.1

@scotje scotje added this to the August 2019 milestone Aug 14, 2019
@rodjek rodjek merged commit 4d80cd7 into puppetlabs:master Aug 14, 2019
@rodjek rodjek deleted the pdk-871 branch August 14, 2019 23:46
@rodjek rodjek mentioned this pull request Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

@glennsarti glennsarti Awaiting requested review from glennsarti

Assignees
No one assigned
Labels
dependency feature
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@rodjek @scotje