(PDK-1443) Windows safe Tempfiles & environment variable access #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
force-pushed
the
pdk-1443
branch
2 times, most recently
from
7ee4849 to
7405f22
Compare
glennsarti
reviewed
Oct 25, 2019
| @@ -10,6 +10,8 @@ class Command | |||
| attr_accessor :environment | |||
| attr_writer :exec_group | |||
|
|
|||
| TEMPFILE_MODE = File::RDWR | File::BINARY | File::CREAT | File::TRUNC | |||
glennsarti
reviewed
Oct 25, 2019
| @@ -19,8 +21,8 @@ def initialize(*argv) | |||
| @process = ChildProcess.build(*@argv) | |||
| @process.leader = true | |||
|
|
|||
| @stdout = Tempfile.new('stdout').tap { |io| io.sync = true } | |||
| @stderr = Tempfile.new('stderr').tap { |io| io.sync = true } | |||
| @stdout = Tempfile.new('stdout', mode: TEMPFILE_MODE).tap { |io| io.sync = true } | |||
There was a problem hiding this comment.
Confirmed this is the only place Tempfile is used in the PDK source. There are many uses in spec tests but that's fine.
glennsarti
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
For reference - the ENV code comes from Puppet and has a whole suite of tests against it. While normally we should probably test all of the FFI wrappers, I'm happy to not do so due to it being tested thoroughly in Puppet and our acceptance tests will stress that it behaves as we expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.