Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#773) Respect --verbose in interactive pdk test unit #791

Merged
merged 1 commit into from
Oct 28, 2019
Merged

(#773) Respect --verbose in interactive pdk test unit #791

merged 1 commit into from
Oct 28, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Oct 28, 2019

pdk test unit will now use the progress formatter (dots) and pdk test unit --verbose will now use the documentation formatter.

Fixes #773

@rodjek rodjek added this to the November 2019 milestone Oct 28, 2019
@rodjek rodjek requested review from scotje and glennsarti October 28, 2019 01:19
@rodjek rodjek requested a review from a team as a code owner October 28, 2019 01:19
@coveralls
Copy link

coveralls commented Oct 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 91.786% when pulling 3f8d0df on rodjek:gh-773 into 9205b4a on puppetlabs:master.

@rodjek
(puppetlabs#773) Respect --verbose in interactive pdk test unit
3f8d0df 
`pdk test unit` will now use the `progress` formatter (dots) and `pdk
test unit --verbose` will now use the `documentation` formatter.

Fixes puppetlabs#773
glennsarti
glennsarti reviewed Oct 28, 2019
View reviewed changes
spec/unit/pdk/test/unit_spec.rb
@@ -309,9 +312,25 @@
end

it 'runs the rake task interactively' do
expect(command).to receive(:execute!).and_return(exit_code: 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is just removing a duplicate expectation (same as the line below?)

@glennsarti glennsarti merged commit 18d814d into puppetlabs:master Oct 28, 2019
@rodjek rodjek deleted the gh-773 branch October 28, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennsarti glennsarti glennsarti approved these changes

@scotje scotje Awaiting requested review from scotje

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.

'pdk test unit --verbose' does not change the rspec output format
4 participants
@rodjek @coveralls @glennsarti @chelnak