(GH-808) Implement pdk release subcommand #809
Conversation
glennsarti
requested review from
rodjek and
carabasdaniel
and removed request for
a team
|
Note that this does not implement the sub-sub commands e.g. |
glennsarti
force-pushed
the
daniel_release_command
branch
from
edae59c to
5085cbc
Compare
|
Marked this as |
glennsarti
force-pushed
the
daniel_release_command
branch
2 times, most recently
from
a1864bc to
dff56ab
Compare
| end | ||
| new_version = module_metadata.data['version'] if new_version.nil? | ||
|
|
||
| if new_version != module_metadata.data['version'] |
There was a problem hiding this comment.
Could this be tied to a --force type flag? It seems more likely that someone typos the version (1.0.1 instead of 1.1.0) and automatically changing it without specific acknowledgement of the difference could lead to undesired results.
There was a problem hiding this comment.
There is an implicit force in play here. The user has to specify --version <...> on the command line in order for that to happen. Adding a requirement for --force as well seems unnecessary as this 2nd command line argument is not intuitive and gives no extra safety.
RFC 003 [1] defines the experience and behavior of the new pdk release sub command. This commit: * Adds the root subcommand `release` with all of the available skip options. This will allow the later `release build` and so on sub-sub-commands to be implemented much easier. Future commits will add these sub-sub commands. * Adds a PDK::Module::Release class which does all of the release process * Adds tests for Release process [1] https://github.com/puppetlabs/pdk-planning/blob/master/RFCs/0003-add-pdk-release.md
Previously the changelog file was hardcoded to CHANGELOG.MD however this is not the default filename. This commit updates the changelog_file method to search for different file extensions for the Changelog. Typically this would only affect case-sensitive file systems. This commit also updates the changelog_content to return an empty string if the changelog file could not be found. This helps modules which are being released for the first time, that may not have a changelog file yet.
glennsarti
force-pushed
the
daniel_release_command
branch
from
dff56ab to
f0a8453
Compare
RFC 003 [1] defines the experience and behavior of the new pdk release sub
command. This commit:
Adds the root subcommand
releasewith all of the available skip options.This will allow the later
release buildand so on sub-sub-commands to beimplemented much easier. Future commits will add these sub-sub commands.
Adds a PDK::Module::Release class which does all of the release process
Adds tests for Release process
[1] https://github.com/puppetlabs/pdk-planning/blob/master/RFCs/0003-add-pdk-release.md