(GH-808) Implement pdk release prep and publish subcommands #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the pdk release command was added. This commit adds the prep and publish subcommands as per PDK RFC 003. This commit also adds tests for new subcommands.
glennsarti
force-pushed
the
enhance-pdk-release
branch
from
82cdafb to
c354423
Compare
glennsarti
changed the title
rodjek
approved these changes
Dec 9, 2019
| end | ||
|
|
||
| it 'does not start an interview when --force is used' do | ||
| expect(PDK::CLI::Util::Interview).to receive(:new).never |
There was a problem hiding this comment.
Suggested change
| expect(PDK::CLI::Util::Interview).to receive(:new).never | |
| expect(PDK::CLI::Util::Interview).not_to receive(:new) |
nit: use a negative expectation rather than a negative matcher for consistency (here and in the other specs in this PR)
There was a problem hiding this comment.
Whoops. Good catch.
There was a problem hiding this comment.
Added an extra commit as I found a bunch of other tests that should be changed as well.
Previously there were many cases of using a negative matcher instead of using a negative expectation. This commit changes use of `.never` to `.not_to` to be consistent with the rest of the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the pdk release command was added. This commit adds the prep and
publish subcommands as per PDK RFC 003.
This commit also adds tests for new subcommands.
The
pdk release buildsub command needs more work, specifically around the tagging component.Closes #808