(PDK-1614) Add project.environment settings #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
modify-repo-context
branch
2 times, most recently
from
8cd14ea to
4663681
Compare
5 tasks
rodjek
approved these changes
Feb 24, 2020
Now that the PDK can read the environment.conf file, it can be updated to display that the user, and be consumed by the Control Repo context. This commit: * Adds a helper method to PDK::ControlRepo to create an an object to read/edit an arbitrary environment.conf file. The helper method also adds the default settings as per Puppet documentation * Updates the PDK::Config class to take in a PDK Context. The configuration settings then are mutated depending on the Context, for example, the 'puppet.environment.*' settings now exist if the user is in a Control Repo, and won't if they're in a Module. Note that because PDK::Config now depends on a PDK::Context object being passed in (or default via PDK.context), any method calls to configuration information (ala PDK.config) are not allowed and can cause circular references and stack overflows. Thus there is a helper class to create the environment.conf IniFile object. Note that right now there is no project-level PDK configuration file therefore the mock configuration RSpec context does not mock this and that the PDK::Config.project_config method has no filename associated with it. Future commits may add this feature.
glennsarti
force-pushed
the
modify-repo-context
branch
from
4663681 to
f14a252
Compare
|
Typo fixed. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the PDK can read the environment.conf file, it can be updated to
display that the user, and be consumed by the Control Repo context. This commit:
an arbitrary environment.conf file. The helper method also adds the default
settings as per Puppet documentation
settings then are mutated depending on the Context, for example, the
'puppet.environment.*' settings now exist if the user is in a Control Repo,
and won't if they're in a Module.
Note that because PDK::Config now depends on a PDK::Context object being
passed in (or default via PDK.context), any method calls to configuration
information (ala PDK.config) are not allowed and can cause circular
references and stack overflows. Thus there is a helper class to create the
environment.conf IniFile object.
Note that right now there is no project-level PDK configuration file therefore
the mock configuration RSpec context does not mock this and that the
PDK::Config.project_config method has no filename associated with it. Future
commits may add this feature.