(FIXUP) Make system config path absolute instead of relative on POSIX hosts #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
commented
Feb 27, 2020
| @@ -349,7 +349,7 @@ | |||
| end | |||
|
|
|||
| it 'returns a path inside the system opt directory' do | |||
| is_expected.to eq(File.join('opt', 'puppetlabs', 'pdk', 'config')) | |||
| is_expected.to match(%r{\A/opt/}) | |||
There was a problem hiding this comment.
We can make this more specific if we want, but this test now better matches its description.
|
We should look at getting some acceptance tests going for this as well |
rodjek
approved these changes
Feb 27, 2020
4 tasks
|
@rodjek Did you want the acceptance tests in this PR? Also acceptance tests for this particular method seem difficult to write. It's only a 4 line method. I agree that there should be acceptance (or packaging) tests for the things that consume this. IMO, In this case adding more tests wouldn't help confidence, because the original tests were wrong, not that they were incomplete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much what it says on the tin.