(PDK-1632) Only show validators that are available in the given PDK Context #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
ignore-invalid-contexts
branch
from
409ea7c to
ca7dfa2
Compare
glennsarti
changed the title
rodjek
approved these changes
Mar 5, 2020
…ontext Previously when a validator was created which was not valid in the PDK Context, for example environment.conf validation in a Puppet Module, the validator would not be invoked but a message would be logged saying that the validator had no targets. This is slightly confusing for users. This commit changes the behaviour so that validators which are not valid in the current PDK Context (Validator.is_valid_context?) are never run or have any targets parsed. This commit also updates the tests for these scenarios.
glennsarti
force-pushed
the
ignore-invalid-contexts
branch
from
ca7dfa2 to
a7fd5ae
Compare
|
Updated comment in validate_spec.rb as per @rodjek comments in slack. Will merge once CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a validator was created which was not valid in the PDK Context,
for example environment.conf validation in a Puppet Module, the validator would
not be invoked but a message would be logged saying that the validator had no
targets. This is slightly confusing for users.
This commit changes the behaviour so that validators which are not valid in the
current PDK Context (Validator.is_valid_context?) are never run or have any
targets parsed.
This commit also updates the tests for these scenarios.