(PDK-1109) Add pdk remove config #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the PDK::Config class now has a set method, we can add a `remove config` CLI command so users can remove configuration values. This commit: * Adds the basic `pdk remove config` command * Adds tests for the CLI command
glennsarti
force-pushed
the
pdk-1109-pdk-remove-config
branch
from
5dc43f2 to
ee822d7
Compare
glennsarti
changed the title
glennsarti
changed the title
|
I'll need to put up a PR to ammend the RFC |
|
|
rodjek
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on puppetlabs-toy-chest/pdk-planning#70Now that the PDK::Config class now has a set method, we can add a
remove configCLI command so users can remove configuration values.
This commit:
pdk remove configcommand