(#869) Ensure bundle update on convert/update #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
force-pushed
the
gh-869
branch
2 times, most recently
from
17f5359 to
c56f07d
Compare
glennsarti
reviewed
Mar 12, 2020
| PDK::Util::Bundler.ensure_bundle! | ||
| end | ||
| require 'pdk/util/bundler' | ||
| PDK::Util::Bundler.ensure_bundle! |
There was a problem hiding this comment.
Should this be a user prompt?
Would you like to update your bundle?
There was a problem hiding this comment.
No, I don't think so. If it doesn't update, then it'll just happen automatically when they run the next PDK command.
There was a problem hiding this comment.
Only usecase I can think of is bundle taking FOREVER (looking at you Windows) and wanting to stop that for tools like pdksync. But I'm more than happy to add that later if needs be.
|
Could probably copy the PR comment into the commit message too. |
Change the update & convert process so that it always ensures the bundle is up to date. Depending on detecting changes to `Gemfile` is not sufficient as it doesn't detect changes to unlisted dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the upgrade & convert process so that it always ensures the bundle is up to date. Depending on detecting changes to
Gemfileis not sufficient as it doesn't detect changes to unlisted dependencies.Fixes #869