Add ability to generate new facts #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logicminds
changed the title
DavidS
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Code looks great, still needs CI sorted.
- was trying to use pdk-templates#main, which didn't have the template yet; it is merged now
- rubocop complaining about whitespace - will push a fixup in a second - see Add ability to generate new facts #923
|
@logicminds the test failures (now that the pdk-templates change has been merged) looks a lot more sensible. Can you work with those? |
logicminds
force-pushed
the
new_fact
branch
2 times, most recently
from
d8e72d1 to
849ec91
Compare
* previously there was not a way to create facts
from the new command. This adds a generator to create
the fact and spec file.
|
I updated the code and removed the failing tests. I don't know how these tests work and without docs I can really move forward without wasting time. A document for acceptance testing generators would be great. I have another branch with a functions generator coming as well. |
|
Hi @logicminds, Thanks for your contribution, this looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new generator to create facts. This must be merged along with puppetlabs/pdk-templates#361.
Currently these tests are failing as I need help figuring out why. Real world testing seems to work fine.
Below is a video showing the usage. The fact generated is very basic as is the spec file but this is enough to save a few minutes from the user.