-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Facter4 to be co-installed with PDK #941
Conversation
Previously facter was locked to 2.5.7. As we're planning to increaase the minimum supported Facter version in Puppet 7 to at least 3, we should update this in PDK as well. Otherwise, projects using the latest puppet would not be able to install PDK.
The AppVeyor failure doesn't seem transient, will try to reproduce locally |
0805268
to
cb4159a
Compare
I think it's transient after all. run 1: https://ci.appveyor.com/project/puppetlabs/pdk/builds/37688744/job/w4g246po84bf1auw
run 2: https://ci.appveyor.com/project/puppetlabs/pdk/builds/37703459/job/qpxbc3e3qxseeekg
I managed to RDP into an appveyor worker and got yet another test to fail, so my guess is that there are rubygems connection hiccups which cause versions of gems not to be found correctly. |
Previously facter was locked to 2.5.1. As we're planning to increaase the minimum supported Facter version in Puppet 7 to at least 3, we should update this in PDK as well. Otherwise, projects using the latest puppet would not be able to install PDK.