Add deprecated tag #342
Merged
Add deprecated tag #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good and tests are passing. Just one thing I noticed that we can maybe tidy up. The description being used for deprecated is "Use a something else". Could you possibly change the message a bit so it's more relevant to the deprecation of something and a little softer? Maybe along the lines of "no longer supported and will be removed in a future release". Thanks! |
|
thanks for the comments
|
|
Looks like you have a couple of rubocop violations to clear up. Once they are done I'm happy to get this merged! |
I had a stab at adding the deprecated flag Fixes puppetlabs#339
|
updated hopefully all green now |
chelnak
approved these changes
Mar 15, 2023
|
@b4ldr Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a stab at adding the deprecated flag
Fixes #339