Change stop_wait_time value to match Docker default
#858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Docker documentation¹, the `--time` option default value is 10 seconds. [1] https://docs.docker.com/engine/reference/commandline/stop/
|
|
docker::run is a typeBreaking changes to this file WILL impact these 9 modules (exact match):Breaking changes to this file MAY impact these 22 modules (near match):
This module is declared in 6 of 579 indexed public
|
neomilium
approved these changes
Sep 16, 2022
smortex
changed the title
stop_wait_time value to Docker defaultstop_wait_time value to match Docker default
LukasAud
approved these changes
Oct 10, 2022
|
LGTM. Failures are unrelated. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Docker documentation, the
--timeoption default value is 10 seconds.The module set this value to 0, causing immediate destruction of the container instead of leaving it a 10s grace time to shutdown.
Use the default value of 10 to honor the default behavior.