Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-351) Syntax update #901

Merged
merged 2 commits into from
Mar 3, 2023
Merged

(CONT-351) Syntax update #901

merged 2 commits into from
Mar 3, 2023

Conversation

LukasAud
Copy link
Contributor

@LukasAud LukasAud commented Feb 20, 2023

Code now compliant with rules regarding:

top-scope facts
legacy facts
top-scope variables
parameter datatypes
parameter documentation

Code now compliant with rules regarding:

top-scope facts
legacy facts
top-scope variables
smortex
smortex previously approved these changes Feb 21, 2023
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud
Copy link
Contributor Author

Still in draft, going to be pushing a round of datatypes and some documentation soon.

@LukasAud LukasAud marked this pull request as ready for review February 21, 2023 11:29
@LukasAud LukasAud requested a review from a team as a code owner February 21, 2023 11:29
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 9d18e68 into main Mar 3, 2023
@david22swan david22swan deleted the CONT-351-Syntax_update branch March 3, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants