Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CONT-256) Removing outdated code #1084

Merged
merged 4 commits into from
Nov 4, 2022
Merged

(CONT-256) Removing outdated code #1084

merged 4 commits into from
Nov 4, 2022
+34 −172

Conversation

LukasAud
Copy link
Contributor

@LukasAud LukasAud commented Nov 3, 2022

Prior to this commit, the firewall modules had multiple instances of outdated code.

This commit aims to clean-up some of that code to keep the module clean and readable.

@LukasAud
(CONT-256) Removing outdated code
61ea9e7 
Prior to this commit, the firewall modules had multiple instances of
outdated code.

This commit aims to clean-up some of that code to keep the module clean
and readable.
@LukasAud LukasAud requested a review from a team as a code owner November 3, 2022 12:27
@puppet-community-rangefinder
Copy link

firewall is a type

Breaking changes to this file WILL impact these 122 modules (exact match):
Breaking changes to this file MAY impact these 154 modules (near match):

firewall::linux::debian is a class

that may have no external impact to Forge modules.

firewall::linux::redhat is a class

that may have no external impact to Forge modules.

firewall::params is a class

that may have no external impact to Forge modules.

This module is declared in 106 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

david22swan
david22swan requested changes Nov 3, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oe small comment and a syntax fix.
Otherwise looks good

manifests/linux/debian.pp Show resolved Hide resolved
david22swan
david22swan approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 0070c25 into main Nov 4, 2022
@david22swan david22swan deleted the CONT-256-module_cleanup branch November 4, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasAud @david22swan