Negation support #267
Merged
Negation support #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Not sure why the build is failing, but it doesn't appear related to this change. Looks like it started failing 8 days ago: https://travis-ci.org/puppetlabs/puppetlabs-firewall/builds/15177064 |
This was referenced Dec 19, 2013
A custom provider should probably be aware that these kind of masks are possible.
…ination and source
| @@ -167,6 +167,10 @@ def self.rule_to_hash(line, table, counter) | |||
| # --tcp-flags takes two values; we cheat by adding " around it | |||
| # so it behaves like --comment | |||
| values = values.sub(/--tcp-flags (\S*) (\S*)/, '--tcp-flags "\1 \2"') | |||
| # we do a simular thing for negated address masks (source and destination). | |||
hunner
added a commit
to hunner/puppetlabs-firewall
that referenced
this pull request
Feb 5, 2014
This adds tests mentioned in puppetlabs#141 and MODULES-48 to make sure that they are covered by puppetlabs#267 Closes puppetlabs#141
hunner
added a commit
to hunner/puppetlabs-firewall
that referenced
this pull request
Feb 5, 2014
This adds tests mentioned in puppetlabs#141 and MODULES-48 to make sure that they are covered by puppetlabs#267 Closes puppetlabs#141
cegeka-jenkins
pushed a commit
to cegeka/puppet-firewall
that referenced
this pull request
Oct 23, 2017
Negation support
cegeka-jenkins
pushed a commit
to cegeka/puppet-firewall
that referenced
this pull request
Oct 23, 2017
This adds tests mentioned in puppetlabs#141 and MODULES-48 to make sure that they are covered by puppetlabs#267 Closes puppetlabs#141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmit of PR #95 which adds support for negations.
I've been maintaining the code of that PR in my own branch for quite some time now, not noticing that the pull request had been closed. So now I'm creating another PR for it. However I have updated and rebased onto the current master branch.