Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug which arbitrarily limited iniface and outiface parameters #374

Merged
merged 1 commit into from
Aug 26, 2014

Conversation

lejonet
Copy link
Contributor

@lejonet lejonet commented Jun 6, 2014

Setting ingoing and outgoing interfaces are allowed in all chains, even own defined chains are allowed to have rules which specify in- and outgoing interfaces.

…utiface parameters are set in rules, they are allowed in all chains
@vgeyer
Copy link

vgeyer commented Jun 20, 2014

+1

1 similar comment
@web-mi
Copy link

web-mi commented Jun 20, 2014

+1

@cyberious
Copy link
Contributor

Please give details on what Platforms you are trying to fix with this issue.
@itze88 @Lexance @lejonet , just want to make sure we test on ALL Platforms to not break other users who may not have the issue on there platform of choice.

@lejonet
Copy link
Contributor Author

lejonet commented Jul 31, 2014

Mainly it is the linux platform, with netfilter and iptables. But in general, I
haven't seen a firewall solution which only allows you to specify in- or
outgoing interface in the input, for ingoing, and output, for outgoing, chains.

@puppetcla
Copy link

Waiting for CLA signature by @lejonet

@lejonet - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

@vgeyer
Copy link

vgeyer commented Aug 14, 2014

My platform is Debian Linux 7, with iptables v1.4.14, and puppetlabs/firewall module on v1.0.2.

@puppetcla
Copy link

CLA signed by all contributors.

hunner added a commit that referenced this pull request Aug 26, 2014
Fixed bug which arbitrarily limited iniface and outiface parameters
@hunner hunner merged commit 7cdd5f1 into puppetlabs:master Aug 26, 2014
cegeka-jenkins pushed a commit to cegeka/puppet-firewall that referenced this pull request Oct 23, 2017
Fixed bug which arbitrarily limited iniface and outiface parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants