(MODULES-450) Enable rule inversion #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures on 2.7... for some reason travisci doesn't show up https://travis-ci.org/puppetlabs/puppetlabs-firewall/builds/31287407 |
|
tried out tcp_flags negation on 3.6.2 and it works |
iptables has many rule arguments that may be inverted by prefixing with an exclamation mark. This commit enables inversion for most every property currently in the firewall provider that supports inversion by prefixing the value with a bang+space. Array elements must have all array elements prefixed with a bang+space otherwise a warning will be raised, as it would look confusing to negate a single value and then have iptables negate all of them.
apenney
pushed a commit
that referenced
this pull request
Aug 1, 2014
(MODULES-450) Enable rule inversion
|
Hey, should inversion work on interfaces (iniface / outiface)? It doesn't seem to for me: Invalid value "! docker0". Valid values match /^[a-zA-Z0-9-._+]+$/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iptables has many rule arguments that may be inverted by prefixing with
an exclamation mark. This commit enables inversion for most every
property currently in the firewall provider that supports inversion by
prefixing the value with a bang+space.
Array elements must have all array elements prefixed with a bang+space
otherwise a warning will be raised, as it would look confusing to negate
a single value and then have iptables negate all of them.