MODULES-1832 - add Gentoo support #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Could you please squash your commits, and maybe update the readme as well. |
derdanne
force-pushed
the
gentoo-compatibility
branch
from
7fefe49 to
b63b7f4
Compare
|
Hi @tphoney, i squashed my commits and updated metadata.json. Could you please specify what to update in readme? I couldn't find any distribution specific part. |
|
I was wondering if there were any OS specific limitations, like there is for SLES. |
|
Hi @tphoney, i did not discover any limitation factors on Gentoo systems so far. The module works for me with the committed changes like it is documented in the readme on many production systems. |
tphoney
added a commit
that referenced
this pull request
Mar 11, 2015
MODULES-1832 - add Gentoo support
|
Thanks @derdanne |
cegeka-jenkins
pushed a commit
to cegeka/puppet-firewall
that referenced
this pull request
Oct 23, 2017
MODULES-1832 - add Gentoo support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Gentoo support