(MODULES 3932) - We need to call Facter.flush to clear Facter cache #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get up to date value for :iptables_persistent_version.
|
It's not, but it sounds valid to me. 👍 |
hunner
added a commit
that referenced
this pull request
Feb 9, 2016
(MODULES 3932) - We need to call Facter.flush to clear Facter cache
| @@ -160,6 +160,9 @@ def persist_iptables(proto) | |||
|
|
|||
| # Older iptables-persistent doesn't provide save action. | |||
| if os_key == 'Debian' | |||
| # We need to call Facter.flush to clear Facter cache as it's possible the cached value will be nil due to the fact | |||
| # that the iptables-persistent package was potentially installed after the initial Fact gathering. | |||
| Facter.flush | |||
There was a problem hiding this comment.
Rather than flushing all facts, this could potentially be more specific with Facter.fact(:iptables_persistent_version).flush, assuming this fact doesn't depend on cached data that is also out of date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to call Facter.flush to clear Facter cache to get up to date value for :iptables_persistent_version.