(MODULES-8584) Handle multiple escaped quotes in comments properly #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-gozdek-sociomantic
force-pushed
the
comments-espace-sequences
branch
2 times, most recently
from
4027da2 to
7969d16
Compare
mateusz-gozdek-sociomantic
force-pushed
the
comments-espace-sequences
branch
from
7969d16 to
1e2fedf
Compare
david22swan
reviewed
Feb 4, 2019
| table: 'filter', | ||
| params: { | ||
| name: '000 parse escaped "s, \'s, and \\s', | ||
| name: '000 parse escaped "s, "s, \'s, \'s, \\s and \\s', |
There was a problem hiding this comment.
Why did you double up each of these?
There was a problem hiding this comment.
To make sure we handle one or more escaped quotes. As my regexp was fine for one escaped ", but not for more, which was the case. I can add it as a separated test if you like.
There was a problem hiding this comment.
Ah, I'm an idiot. Need to stop reviewing first thing on a monday. Will make an adhoc run, and if it passes will merge.
There was a problem hiding this comment.
Haha, cheers!
This comment has been minimized.
This comment has been minimized.
|
|
|
@mateusz-gozdek-sociomantic Thanks for putting in the work :) |
|
Thanks for quick feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.